[PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[Björn Baumbach]

commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
("CIFS: Cleanup cifs open codepath")
changed disposition to FILE_OPEN.

Signed-off-by: Bj=C3=B6rn Baumbach <***@sernet.de>
Signed-off-by: Stefan Metzmacher <***@samba.org>
Reviewed-by: Stefan Metzmacher <***@samba.org>
Cc: <***@vger.kernel.org> # v3.14+
Cc: Pavel Shilovsky <***@etersoft.ru>
Cc: Steve French <***@samba.org>
---
fs/cifs/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 264ece7..68559fd 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cif=
s_tcon *tcon,
oparms.cifs_sb =3D cifs_sb;
oparms.desired_access =3D GENERIC_WRITE;
oparms.create_options =3D create_options;
- oparms.disposition =3D FILE_OPEN;
+ oparms.disposition =3D FILE_CREATE;
oparms.path =3D path;
oparms.fid =3D &fid;
oparms.reconnect =3D false;
--=20
1.7.9.5

[Stefan (metze) Metzmacher]

Hi Steve,

any comments on this? How can we get this fixed upstream?

Thanks!
metze

Post by Björn Baumbach
commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
("CIFS: Cleanup cifs open codepath")
changed disposition to FILE_OPEN.
---
fs/cifs/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 264ece7..68559fd 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
oparms.cifs_sb = cifs_sb;
oparms.desired_access = GENERIC_WRITE;
oparms.create_options = create_options;
- oparms.disposition = FILE_OPEN;
+ oparms.disposition = FILE_CREATE;
oparms.path = path;
oparms.fid = &fid;
oparms.reconnect = false;

[Steve French]

Although I have merged this into cifs-2.6.git for-next, in my testing
I am also seeing this fail with vers=3D3.0 (and probably 2.0 and 2.1) s=
o
I would like to fix that too (and mfsymlinks may be at least as
important there)

On Mon, Jun 16, 2014 at 8:49 AM, Stefan (metze) Metzmacher

Post by Stefan (metze) Metzmacher
Hi Steve,
any comments on this? How can we get this fixed upstream?
Thanks!
metze

Post by Björn Baumbach
commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
("CIFS: Cleanup cifs open codepath")
changed disposition to FILE_OPEN.
---
fs/cifs/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 264ece7..68559fd 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct =

cifs_tcon *tcon,

Post by Stefan (metze) Metzmacher

Post by Björn Baumbach
oparms.cifs_sb =3D cifs_sb;
oparms.desired_access =3D GENERIC_WRITE;
oparms.create_options =3D create_options;
- oparms.disposition =3D FILE_OPEN;
+ oparms.disposition =3D FILE_CREATE;
oparms.path =3D path;
oparms.fid =3D &fid;
oparms.reconnect =3D false;

--=20
Thanks,

Steve

[Stefan (metze) Metzmacher]

Hi Steve,

Post by Steve French
Although I have merged this into cifs-2.6.git for-next, in my testing
I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so
I would like to fix that too (and mfsymlinks may be at least as
important there)

Thanks! When can we expect this to be proposed for 3.16 (and stable
3.14/3.15)?

metze