Discussion:
[GIT] CIFS Fixes
Steve French
2013-11-17 00:14:45 UTC
Permalink
A set of cifs fixes most important of which is Pavel's fix for some
problems with handling Windows reparse points and also the security
fix for setfacl over a cifs mount to Samba removing part of the ACL.
Both of these fixes are for stable as well. Also added most of
copychunk (copy offload) support to cifs although I expect a final
patch in that series (to fix handling of larger files) in a few days
(had to hold off on that in order to incorporate some additional code
review feedback). Also added support for O_DIRECT on forcedirectio
mounts (needed in order to run some of the server benchmarks over cifs
and smb2/smb3 mounts).


The following changes since commit 6c86ae2928f9e4cbf0d5844f5fcfd549e3450b8c:

Merge tag 'ftrace-urgent-3.12-v2' of
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
(2013-11-08 08:54:53 +0900)

are available in the git repository at:


git://git.samba.org/sfrench/cifs-2.6.git for-linus

for you to fetch changes up to 0cbaa53cdd33080c1e2d67ad9295b83c7954f2b3:

[CIFS] Warn if SMB3 encryption required by server (2013-11-15 23:50:24 -0600)

----------------------------------------------------------------
Jeff Layton (2):
cifs: change ERRnomem error mapping from ENOMEM to EREMOTEIO
cifs: don't spam the logs on unexpected lookup errors

Pavel Shilovsky (1):
CIFS: Fix symbolic links usage

Steve French (5):
[CIFS] O_DIRECT opens should work on directio mounts
CIFS: SMB2/SMB3 Copy offload support (refcopy) phase 1
[CIFS] Set copychunk defaults
setfacl removes part of ACL when setting POSIX ACLs to Samba
[CIFS] Warn if SMB3 encryption required by server

Tim Gardner (1):
cifs: Use data structures to compute NTLMv2 response offsets

fs/cifs/cifsencrypt.c | 40 +++++++++++-------
fs/cifs/cifsglob.h | 8 +++-
fs/cifs/cifspdu.h | 8 +++-
fs/cifs/cifssmb.c | 8 ++--
fs/cifs/dir.c | 2 +-
fs/cifs/file.c | 22 ++++++++++
fs/cifs/inode.c | 23 +++++-----
fs/cifs/ioctl.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++++
fs/cifs/netmisc.c | 2 +-
fs/cifs/readdir.c | 40 ++++--------------
fs/cifs/smb1ops.c | 21 +++++++++-
fs/cifs/smb2inode.c | 16 +++++--
fs/cifs/smb2maperror.c | 2 +-
fs/cifs/smb2ops.c | 82 ++++++++++++++++++++++++++++++++++++
fs/cifs/smb2pdu.c | 12 +++++-
fs/cifs/smb2pdu.h | 33 ++++++++++++++-
fs/cifs/smb2proto.h | 2 +-
17 files changed, 358 insertions(+), 74 deletions(-)
--
Thanks,

Steve
Steve French
2013-11-21 03:54:21 UTC
Permalink
Small set of changes this time. As promised, the finish up of
the copy offload support, and a small security feature for SMB3
needed to prevent certain types of downgrade attacks.

The following changes since commit 2d3c627502f2a9b0a7de06a5a2df23
65542a72c9:

Revert "init/Kconfig: add option to disable kernel compression"
(2013-11-17 11:17:36 -0800)

are available in the git repository at:

git://git.samba.org/sfrench/cifs-2.6.git for-next

for you to fetch changes up to ff1c038addc4f205d5f1ede449426c7d316c0eed:

Check SMB3 dialects against downgrade attacks (2013-11-19 23:52:54 -0600)

----------------------------------------------------------------
Steve French (3):
CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files
Removed duplicated (and unneeded) goto
Check SMB3 dialects against downgrade attacks

fs/cifs/cifsglob.h | 1 +
fs/cifs/smb2ops.c | 99 ++++++++++++++++++++++++++++++++++++++++++++++-------
fs/cifs/smb2pdu.c | 92 ++++++++++++++++++++++++++++++++++++++++++++++---
fs/cifs/smb2pdu.h | 12 +++++--
fs/cifs/smb2proto.h | 1 +
fs/cifs/smbfsctl.h | 2 +-
6 files changed, 185 insertions(+), 22 deletions(-)
--
Thanks,

Steve
Christoph Hellwig
2013-11-21 07:37:43 UTC
Permalink
Post by Steve French
Small set of changes this time. As promised, the finish up of
the copy offload support, and a small security feature for SMB3
needed to prevent certain types of downgrade attacks.
The following changes since commit 2d3c627502f2a9b0a7de06a5a2df23
NAK. Multiple people have told you you should not abuse the btrfs
reflink ioctl for the semantically different cifs copy offloading.
Continue reading on narkive:
Loading...