Discussion:
[PATCH linux-next] cifs: remove unused function cifs_oplock_break_wait
Vincent Stehlé
2014-07-21 21:47:36 UTC
Permalink
Commit 743162013d40 ("sched: Remove proliferation of wait_on_bit() acti=
on
functions") has removed the call to cifs_oplock_break_wait, making this
function unused; remove it.

This fixes the following compilation warning:

fs/cifs/misc.c:578:1: warning: =E2=80=98cifs_oplock_break_wait=E2=80=99=
defined but not used [-Wunused-function]

Signed-off-by: Vincent Stehl=C3=A9 <***@laposte.net>
Cc: Steve French <***@samba.org>
---

Hi,

This can be seen with e.g. linux next-20140721 and arm allmodconfig.

Best regards,

V.

fs/cifs/misc.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 9a70792..65c2682 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -574,13 +574,6 @@ void cifs_set_oplock_level(struct cifsInodeInfo *c=
inode, __u32 oplock)
cinode->oplock =3D 0;
}
=20
-static int
-cifs_oplock_break_wait(void *unused)
-{
- schedule();
- return signal_pending(current) ? -ERESTARTSYS : 0;
-}
-
/*
* We wait for oplock breaks to be processed before we attempt to perf=
orm
* writes.
--=20
2.0.1
Steve French
2014-08-10 19:11:10 UTC
Permalink
merged into cifs-2.6.git for-next

On Mon, Jul 21, 2014 at 4:47 PM, Vincent Stehlé
Commit 743162013d40 ("sched: Remove proliferation of wait_on_bit() action
functions") has removed the call to cifs_oplock_break_wait, making this
function unused; remove it.
fs/cifs/misc.c:578:1: warning: ‘cifs_oplock_break_wait’ defined but not used [-Wunused-function]
---
Hi,
This can be seen with e.g. linux next-20140721 and arm allmodconfig.
Best regards,
V.
fs/cifs/misc.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index 9a70792..65c2682 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -574,13 +574,6 @@ void cifs_set_oplock_level(struct cifsInodeInfo *cinode, __u32 oplock)
cinode->oplock = 0;
}
-static int
-cifs_oplock_break_wait(void *unused)
-{
- schedule();
- return signal_pending(current) ? -ERESTARTSYS : 0;
-}
-
/*
* We wait for oplock breaks to be processed before we attempt to perform
* writes.
--
2.0.1
--
Thanks,

Steve
Loading...