[PATCH v2] get/setcifsacl: fix bad bit-shifts

[Jeff Layton]

A Coverity scan turned up this warning:

1. cifs-utils-6.2/setcifsacl.c:578:result_independent_of_operands =E2=80=
=93 "(x & 0xff0000000000ULL) >> 48" is 0 regardless of the values of it=
s operands. This occurs as the operand of assignment.

=2E..which is entirely true. That shift should be 40 bits, not 48. Also
fix a similar bug in getcifsacl.c.

Signed-off-by: Jeff Layton <jlayton-***@public.gmane.org>
---
getcifsacl.c | 2 +-
setcifsacl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/getcifsacl.c b/getcifsacl.c
index b8998ef..33f36b4 100644
--- a/getcifsacl.c
+++ b/getcifsacl.c
@@ -198,7 +198,7 @@ print_sid_raw:
id_auth_val +=3D (unsigned long long)csid->authority[3] << 16;
id_auth_val +=3D (unsigned long long)csid->authority[2] << 24;
id_auth_val +=3D (unsigned long long)csid->authority[1] << 32;
- id_auth_val +=3D (unsigned long long)csid->authority[0] << 48;
+ id_auth_val +=3D (unsigned long long)csid->authority[0] << 40;
=20
/*
* MS-DTYP states that if the authority is >=3D 2^32, then it should =
be
diff --git a/setcifsacl.c b/setcifsacl.c
index ce708eb..7eeeaa6 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -575,7 +575,7 @@ raw_str_to_sid(const char *str, struct cifs_sid *cs=
id)
csid->authority[3] =3D (x & 0x000000ff0000ULL) >> 16;
csid->authority[2] =3D (x & 0x0000ff000000ULL) >> 24;
csid->authority[1] =3D (x & 0x00ff00000000ULL) >> 32;
- csid->authority[0] =3D (x & 0xff0000000000ULL) >> 48;
+ csid->authority[0] =3D (x & 0xff0000000000ULL) >> 40;
=20
/* now read the the subauthorities and store as __le32 vals */
p =3D q + 1;
--=20
1.8.3.1